Skip to content

Comments

Change hover color of links in footer#41461

Closed
magnussinger wants to merge 1 commit intojoomla:4.4-devfrom
magnussinger:i41172
Closed

Change hover color of links in footer#41461
magnussinger wants to merge 1 commit intojoomla:4.4-devfrom
magnussinger:i41172

Conversation

@magnussinger
Copy link
Contributor

Pull Request for Issue #41172.

Summary of Changes

The color of the links stay the same when one hovers or focusses them

Testing Instructions

Create a footer module and hover over the links, the color should not change

Actual result BEFORE applying this Pull Request

The color went to a not readable one when the user hovered the links in the footer

Expected result AFTER applying this Pull Request

The color now stays constant

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Aug 26, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 26, 2023
@richard67 richard67 added the bug label Aug 26, 2023
@sandewt
Copy link
Contributor

sandewt commented Aug 26, 2023

See #40435 (comment)

@KingLouis1
Copy link

I have not tested this item.

Issue could be reproduced.
But the patch could not be applied. The following message was pops up: "The file marked for modification does not exist: build/media_source/templates/site/cassiopeia/scss/blocks/_footer.scss"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41461.

@magnussinger
Copy link
Contributor Author

@magnussinger
Copy link
Contributor Author

See #40435 (comment)

Does this mean this PR can be closed?

@sandewt
Copy link
Contributor

sandewt commented Aug 28, 2023

Does this mean this PR can be closed?

I'll wait for comments before I try another PR.

[EDIT If yes, then this pr is unnecessary]

@sandewt
Copy link
Contributor

sandewt commented Sep 14, 2023

Please test PR #41749

@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:43
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@laoneo
Copy link
Member

laoneo commented Oct 3, 2023

Can this be closed in favour of #41749?

@HLeithner
Copy link
Member

thanks for your work @magnussinger but I'm closing this in favor for #41749 as suggested by allon and viviana

@HLeithner HLeithner closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester PBF Pizza, Bugs and Fun PR-4.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants